implement subsetof filter operator #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalperi
changed the title
Contributor
|
lgtm, cc @kallestenflo |
Contributor
|
@dhalperi, could you please close and reopen the PR to make Travis run a build? |
Contributor
Author
|
@jochenberger done! |
Contributor
Author
|
Looks like it passed. Please let me know if there's more work to be done. |
Contributor
|
We can probably close #337 then |
Contributor
Author
|
If I may also ask for my own curiosity, what's the planned release schedule for JsonPath? I notice you made a release last week after ~16 months. Is there a plan for more frequent releases going forward? (We've been using a hacked version of JsonPath for a while, but when I saw releases resuming again we decided to try and upstream the last remaining hacks.) |
cmunilla
pushed a commit
to cmunilla/JPath
that referenced
this pull request
Oct 30, 2017
implement subsetof filter operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extension of #337 updated with reviewer feedback.
subsetofis a better name thansubset-- it type-checks grammatically against things likeinornotinorequals. (though to be fair,sizeandemptydo not type-check the same way.)sizetests.I included the original commit from the original author.
Please let me know if there is additional work to do to make this ready for merging.
Thanks!