Skip to content

Add redir from /minutes/ to minutes subdomain. #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

BigBlueHat
Copy link
Member

@BigBlueHat BigBlueHat commented Apr 23, 2025

Last bit of #836 to redirect /minutes/* to https://minutes.json-ld.org/:splat

Copy link

cloudflare-workers-and-pages bot commented Apr 23, 2025

Deploying json-ld-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2318616
Status: ✅  Deploy successful!
Preview URL: https://940b8600.json-ld-org.pages.dev
Branch Preview URL: https://add-minutes-redirect.json-ld-org.pages.dev

View logs

@BigBlueHat BigBlueHat force-pushed the add-minutes-redirect branch from e9b0943 to 2318616 Compare April 23, 2025 19:15
@BigBlueHat
Copy link
Member Author

BigBlueHat commented Apr 23, 2025

You can test a redirect with https://add-minutes-redirect.json-ld-org.pages.dev/minutes/2022-09-12/ which should deposit you at https://minutes.json-ld.org/2022-09-12/

Copy link
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _redirects ordering is odd.

@davidlehn davidlehn merged commit 290dde6 into main Apr 23, 2025
1 check passed
@davidlehn davidlehn deleted the add-minutes-redirect branch April 23, 2025 20:15
@BigBlueHat
Copy link
Member Author

The _redirects ordering is odd.

We can resort them, but anything dynamic should go last as it's a first-come-first-served thing and dynamic stuff takes longer (as anywhere) than static matches.

The order they're in now is based on the order I handled the .htaccess migration...no more no less (other than the above caveat).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants