Skip to content

Allow to override valueconverter on FilterParser #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Allow to override valueconverter on FilterParser #1401

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6a8149
Allow to override converters on FilterParser
bjornharrtell Nov 21, 2023
13d9e00
Make non static and virtual
bjornharrtell Nov 22, 2023
e783c80
Merge branch 'master' into allow-converters-override
bjornharrtell Nov 22, 2023
b4094c5
Replace anon Func type with delegate
bjornharrtell Nov 22, 2023
410d8f0
Fix docs
bjornharrtell Nov 22, 2023
5cfc2ad
cleanupcode.ps1
bjornharrtell Nov 22, 2023
4a70855
Move to separate unit
bjornharrtell Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make non static and virtual
  • Loading branch information
@bjornharrtell
bjornharrtell committed Nov 22, 2023
commit 13d9e00e4d1d8398f93a6d9aadc6333411a44e28
4 changes: 2 additions & 2 deletions src/JsonApiDotNetCore/Queries/Parsing/FilterParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ private NullConstantExpression ParseNull()
throw new QueryParseException("null expected.", position);
}

protected static Func<string, int, object> GetConstantValueConverterForType(Type destinationType)
protected virtual Func<string, int, object> GetConstantValueConverterForType(Type destinationType)
{
return (stringValue, position) =>
{
Expand All @@ -529,7 +529,7 @@ protected static Func<string, int, object> GetConstantValueConverterForType(Type
};
}

protected Func<string, int, object> GetConstantValueConverterForAttribute(AttrAttribute attribute)
private Func<string, int, object> GetConstantValueConverterForAttribute(AttrAttribute attribute)
{
if (attribute is { Property.Name: nameof(Identifiable<object>.Id) })
{
Expand Down