support jsk_rviz_plugin to be loaded in indigo #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed the segmentation fault in indigo on current master branch, and it is fixed in this PR. |
YutoUchimi
approved these changes
Jun 12, 2019
knorth55
changed the title
|
test passed! |
garaemon
pushed a commit
to garaemon/jsk_visualization
that referenced
this pull request
Oct 1, 2019
support jsk_rviz_plugin to be loaded in indigo
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current
jsk_rviz_pluginsis built with C++11 withstd::shared_ptr. (see #710)This causes rviz load error and segmentation fault in Indigo. (see PointCloudLibrary/pcl#619 (reference))
I support to build old fashion style when ROS version is indigo.