Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fetch] Switch branch of jsk_pr2eus to develop/fetch #1820

Merged
merged 2 commits into from
Jun 21, 2023
Merged

[Fetch] Switch branch of jsk_pr2eus to develop/fetch #1820

merged 2 commits into from
Jun 21, 2023

Conversation

tkmtnt7000
Copy link
Member

To reflect jsk-ros-pkg/jsk_pr2eus#495 until that is merged to master branch.

@tkmtnt7000 tkmtnt7000 merged commit 1cddbe0 into jsk-ros-pkg:develop/fetch Jun 21, 2023
@tkmtnt7000
Copy link
Member Author

Thank you!

@tkmtnt7000 tkmtnt7000 deleted the PR-use-develop-fetch-pr2eu branch June 21, 2023 09:12
@k-okada
Copy link
Member

k-okada commented Jun 22, 2023

I have merged jsk-ros-pkg/jsk_pr2eus#495 so you can revert this PR now
I also changed hoge.py to use insert_at instead of headers. -> tkmtnt7000/jsk_demos@9e4b988#diff-61e0efee72c93663b508c3bb5b33dad88a335d7e66c39aae3dc9a0a4702c20e9R288
Originally I thought this is darty code, but if we have more topics without correct header stamp, may be this is good strategy.

@tkmtnt7000 tkmtnt7000 mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sktometometo sktometometo sktometometo approved these changes

Assignees
No one assigned
Labels
develop/fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkmtnt7000 @k-okada @sktometometo