-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fetch] [PR2] [Baxter] [Unitree] Generate (robot)_email_topic.yaml when building workspace #1646
base: master
Are you sure you want to change the base?
[Fetch] [PR2] [Baxter] [Unitree] Generate (robot)_email_topic.yaml when building workspace #1646
Conversation
# Create email config for PR2 | ||
macro(configure_email_topic_yaml rname) | ||
cmake_host_system_information(RESULT PR2_NAME QUERY HOSTNAME) | ||
if (${PR2_NAME} MATCHES ^${rname}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (${PR2_NAME} MATCHES ^${rname}) | |
if (${PR2_NAME} STREQUAL "pr1012" OR ${PR2_NAME} STREQUAL "pr1040") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, do we need to check if the machine's hostname?
we can compile yaml file in any machine, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f5372be
to
8955b99
Compare
https://github.com/jsk-ros-pkg/jsk_robot/pull/1646/files#diff-2d20033b5d7cadf9aef4bae5433328477862903543682887dc7ebdd535e20dddR67-R68 |
as I said in #1634 (comment) and k-okada@37b71ce#r87121340, So we need to add a new argument like
|
how about
|
hmmm... it looks pretty complicated, but it may work. |
Almost same as #1634. Reflect #1588 .
In this PR, an email config file is auto-generated when we build workspace.
(robot_name)_email_topic.yaml
is loaded when robot starts.