Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_topic_tools] add_rostest problem should be fixed in latest catkin #1190

Merged

Conversation

wkentaro
Copy link
Member

No description provided.

@wkentaro wkentaro force-pushed the comment-out-if-block-for-add-rostest branch from 1ba93fc to 4529699 Compare October 18, 2015 05:58
@wkentaro
Copy link
Member Author

@k-okada jenkins does not return value.
image

@k-okada
Copy link
Member

k-okada commented Oct 19, 2015

明らかにおかしいのでrebootしました
screenshot from 2015-10-19 17 54 18

if (NOT $ENV{ROS_DISTRO} STREQUAL "indigo")
# ``add_rostest`` should work with latest catkin on even if indigo
# See: https://github.com/jsk-ros-pkg/jsk_common/pull/1178#discussion_r41753604
# if (NOT $ENV{ROS_DISTRO} STREQUAL "indigo")
add_rostest(test/test_topic_buffer.test)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent

@wkentaro wkentaro force-pushed the comment-out-if-block-for-add-rostest branch from 4529699 to 9a0b0d8 Compare October 19, 2015 10:01
@garaemon
Copy link
Member

@k-okada dockerがとまってslackからrestartしてもうまくいかなくなっていました

@wkentaro
Copy link
Member Author

🙏

garaemon added a commit that referenced this pull request Oct 22, 2015
…ostest

[jsk_topic_tools] ``add_rostest`` problem should be fixed in latest catkin
@garaemon garaemon merged commit 29533f1 into jsk-ros-pkg:master Oct 22, 2015
@wkentaro wkentaro deleted the comment-out-if-block-for-add-rostest branch October 22, 2015 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants