translate the "merkleize multiple entries" test from python #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
gballet
commented
May 21, 2025
| // which is what I get in the go code as well. | ||
| assert_eq!( | ||
| hex::encode(hash), | ||
| "e93c209026b8b00d76062638102ece415028bd104e1d892d5399375a323f2218" |
There was a problem hiding this comment.
there's no CI so I'm pointing it out here: this value coming from the python code seems to be incorrect.
There was a problem hiding this comment.
There is CI, just had to approve the run. We can see it fail now.
Let's check first the Python situation and we can update the hash here after.
jsign
reviewed
May 22, 2025
| keys[3][0] = 0x81; | ||
| for i in 0..keys.len() { | ||
| let mut new_array = [0u8; 32]; | ||
| new_array[0] = i as u8; |
There was a problem hiding this comment.
Suggested change
| new_array[0] = i as u8; | |
| new_array[0] = (i+1) as u8; |
as specified in https://github.com/jsign/binary-tree-spec/blob/main/test_tree.py#L83 passes the test correctly with the original state root from the specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I translated the python test that fails in go, and as it turns out, it's failing with this library as well. This seems to indicate (but it needs to be confirmed) that the python implementation has a bug.