Add support for status code 530 #15
Conversation
|
Are you sure the status message for this is "Site is frozen"? No where in the entire article you sent are those words used, so I'm skeptical. Can you show the output of a Also may help if you add a little bit more background around why you're trying to get the code added to the list here as well, especially since it's not IANA and because it's adding an entire new category :) |
|
I am not. I don't have the actual status text and that one was sourced from errorcodelist.com. It might be interesting to add the other Unofficial ones if that's a category you would like to entertain. I'm currently working on setting up an invalid domain on Cloudflare to obtain the status text, as I'm curious about it as well. As to the why, with Cloudflare becoming an important backbone of content delivery on the internet, the chance of receiving a response with this status code is increasing. If proxying this response to a koa app (for whatever reasons there might be to do so), it will fail due to this check. |
|
Yea, but all those lists show 530 that a site called Pantheon returns (which is the "Site is frozen") and has no relation to Cloudflare's 530. This module is not meant to categorize all possible statues code from all providers, especially when they conflict. 530 is a conflicting one, because both Pantheon and Cloudflare are using it for different purposes. How can we possibly add it to this module in that condition? For the Koa check, this has been discussed here a few times, and in the end I don't understand what the purpose of that check is. The HTTP spec clearly states that any code in the format |
No status text is sent. I thought it was an issue with logging :-)
Right, I understand your point, but at the same it's a pretty subjective line (which I respect) - but it's difficult to compare different dimensions (apache vs Cloudflare). I think that given the fact that no status text is included, it doesn't make sense to include it in the module as that's part of its functionality.
Just a note on this one - I guess that can happen with any code unassigned in IANA. 418, 425 and 509 can be introduced in a new web framework at any time and each represent something different than what's been included in the module.
I think this is a very valid point and I agree that this validation should be removed from koa. It seems like this has been discussed before on this repository one way or another, although I believed 530 had more widespread usage than what further evidence proved in the meantime. Thanks for your time and patience! |
|
Yea, I mean, every boundary for any module is going to be subjective to the original author. If not, then why shouldn't all of this, including even Koa just be part of Node.js directly? There is a subjective line that divides these apart. Ultimately I'm just trying to remove everything that just isn't driven by the IANA list, but also the subjective line for the codes included here are just for lookups, mainly for server responses. The Conflicts are the hardest thing to manage, and the IANA has an entire process to resolve that, and I would rather create a module that is programatic to the IANA registry rather than become a registry myself, including all the issues that go along with that like conflict resolution. Ultimately if you are passing a reverse proxy though this module for validation as your use-case, I don't think that use-case ultimately makes sense, and that adding 530 would just fix this one issue, but you'll still end up with other codes appearing all of a sudden. |
Cloudflare returns a 530 if there is a DNS error on the origin. Not really sure how to classify this other than "unofficial". It is a common FTP code, but on an FTP context it means "Not logged in". I'm open to suggestions.
Source: https://support.cloudflare.com/hc/en-us/articles/234979888-Error-1016-Origin-DNS-error