test: fix getAllHeaderNames to use res parameter instead of this#44
Open
Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Open
test: fix getAllHeaderNames to use res parameter instead of this#44Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Conversation
Fix bug in getAllHeaderNames helper function where it incorrectly used 'this._headers' instead of 'res._headers'. This bug would cause the function to fail on Node.js 0.8 (the minimum supported version) because: - Node.js 0.8 doesn't have getHeaderNames() method, so it uses the fallback path that reads from _headers - Inside the function, 'this' is not the response object, so this._headers is undefined - This would cause getAllHeaderNames to always return [] even when headers exist The fix changes 'this._headers' to 'res._headers' to correctly use the response object parameter that was passed to the function. This ensures compatibility with all supported Node.js versions, including Node.js 0.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug in getAllHeaderNames helper function where it incorrectly used 'this._headers' instead of 'res._headers'. This bug would cause the function to fail on Node.js 0.8 (the minimum supported version)
because:
The fix changes 'this._headers' to 'res._headers' to correctly use the response object parameter that was passed to the function.
This ensures compatibility with all supported Node.js versions, including Node.js 0.8.