Skip to content

Conversation

@cjiso1117
Copy link

Add support for text/x-php since file command use text/x-php in debian system

ref: https://cweiske.de/tagebuch/php-mimetype.htm#linux

add support for text/x-php
@cjiso1117
Copy link
Author

is PR review stuck due to broken automation?

@wesleytodd
Copy link
Member

No I think it was stuck due to no one reviewing it. That said, if you look here you see application/x-httpd-php which is already in our data. That article is from 2011 and I am not sure it justifies adding this type.

@cjiso1117
Copy link
Author

cjiso1117 commented Mar 6, 2025

But file command returns text/x-php for most os in 2025, and some mimetype guessers depend on file command and system's mimetype database.

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that is a valid argument. Can you add the source key with your research links?

@cjiso1117 cjiso1117 requested a review from wesleytodd April 14, 2025 07:39
@UlisesGascon UlisesGascon mentioned this pull request Nov 19, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants