Skip to content

documention doesn't match implementation #67

Closed

Description

@marcosmol204

Description

Just check this PR
expressjs/express#6936
I improved the express documentation that relies on this package.

Expectations

Match the actual code

Activity

  1. bjohansebas commented on Jan 16, 2026

    @bjohansebas
    Member

    In which part does it not match the documentation of this package?

  2. krzysdz commented on Jan 18, 2026

    @krzysdz
    Contributor

    In which part does it not match the documentation of this package?

    1. types returns false, not undefined when there is no match
    2. types description doesn't explicitly list a list of arguments as supported input, although it is supported and there are examples that show it (compare with the description in express)
      • accepts/index.js

        Lines 46 to 49 in 04c8970

        * The `type` value may be a single mime type string
        * such as "application/json", the extension name
        * such as "json" or an array `["json", "html", "text/plain"]`. When a list
        * or array is given the _best_ match, if any is returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions