Updates #2
Open
Updates #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m not an expert in licensing but I believe you must keep the original authors MIT copyright statement intact |
Author
|
This is correct. I apologize for removing the mit notice that stays with
the mit licensed code. This was entirely unintentional. I’ll update my
branch in the near future to fix this.
…On Wed, Apr 11, 2018 at 7:07 AM Tim Yardley ***@***.***> wrote:
I’m not an expert in licensing but I believe you must keep the original
authors MIT copyright statement intact
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABJ-AA4CLltkbHtmhY3fuwY1jSGvsnp2ks5tnePjgaJpZM4TOPcn>
.
|
…Secret to better match Nest documentation and REST api usage Update usage to reflect rename
… NestCam Add the Camera struct and add it to the appropriate REST structures
…s on POST, GET, and PUT The PUT redirect support looks like it can be removed as Go 1.8 supports redirection. I'll retest once F26 is out in a few days as it inclues 1.8.
…kRedirect function on PUTs Also refactor httpClient to reduce code duplication
Start with Devices.FindThermostat() a helper to find thermostats by their name
Author
|
Dropped the license changes off, apologizes for my misunderstanding there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Here are some changes I've made when using the library if you are interested in pulling them upstream. Note that I did change the license early on and I can appreciate that this may make the changes not interesting to you. If you'd like to discuss please msg me here.
Chris