Skip to content

Fix queue buildup on unchanged state #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix queue buildup on unchanged state #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/react-reconciler/src/ReactFiberHooks.new.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1870,6 +1870,12 @@ function dispatchAction<S, A>(fiber: Fiber, queue: UpdateQueue<S, A>, action: A,
-- It's still possible that we'll need to rebase this update later,
-- if the component re-renders for a different reason and by that
-- time the reducer has changed.
if pending == nil then
queue.pending = nil
else
pending.next = update.next
queue.pending = pending
end
return
end
-- ROBLOX catch
Expand Down