bug fixed & enhancement

[atom2ueki]

bug fixed

bug fixed for
#32
#27

enhancement - New props/attributes added

pullingIndicator: oneOfType([func, element]) - define the indicator shown when pulling down ( optional )
holdingIndicator: oneOfType([func, element]) - define the indicator shown when pulling down and holding after it exceed the min-distance ( optional )
refreshingIndicator: oneOfType([func, element]) - define the indicator shown when refreshing ( optional )
pullingPrompt: String default 'pull to refresh'
holdingPrompt: String default 'release to refresh'
refreshingPrompt: String default 'loading'

new example added

please refer to this example to learn how to use the version of this PR

[atom2ueki]

@jsdf I'm not sure how to pass travis-ci/pr

[niftylettuce]

Can we get this merged?

[jsdf]

That's the plan

[niftylettuce]

Getting these errors, not sure if you guys can reproduce?

[jsdf]

Okay so I finally got some time to pull down this branch and take a look at it, and I think some of the new features need a bit of polish but I'm mindful that people want the bug fixes so I'm just going to merge those for now.

[atom2ueki]

@jsdf any news on this ?

[jsdf]

Sorry I'm just on holiday at the moment, back this weekend
On Tue, 29 Dec 2015 at 9:00 PM, Tony Li notifications@github.com wrote:

@jsdf https://github.com/jsdf any news on this ?

—
Reply to this email directly or view it on GitHub
#33 (comment)
.

[atom2ueki]

@jsdf no problem, enjoy

[natorojr]

@atom2ueki If you have time, it might be worth separating the bug fix from the enhancement. That way @jsdf can focus on reviewing and merging the bug fix with higher priority (since presumably it involves less code) and then give feedback on the enhancement when he has time.

Just my $0.02

[jsdf]

Ah it's okay, I'm going to fix both at the same time (though with a
different API for passing in the stuff to be rendered for the various
states) because both are release blockers for v2. I'll just manually merge
this code, leaving out the parts which aren't needed.
On Sat, 2 Jan 2016 at 11:31 AM, Nestor Toro notifications@github.com
wrote:

@atom2ueki https://github.com/atom2ueki If you have time, it might be
worth separating the bug fix from the enhancement. That way @jsdf
https://github.com/jsdf can focus on reviewing and merging the bug fix
with higher priority (since presumably it involves less code) and then give
feedback on the enhancement when he has time.

Just my $0.02

—
Reply to this email directly or view it on GitHub
#33 (comment)
.