Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rate limit and credits info & api error refactoring #114

Merged
merged 12 commits into from
Jul 10, 2024
Merged

feat: add rate limit and credits info & api error refactoring #114

merged 12 commits into from
Jul 10, 2024

Conversation

radulucut
Copy link
Collaborator

@radulucut radulucut commented Jul 8, 2024 •
edited
Loading

MartinKolarik
MartinKolarik reviewed Jul 8, 2024
View reviewed changes
globalping/client.go Outdated Show resolved Hide resolved
globalping/client.go Outdated Show resolved Hide resolved
globalping/client.go Outdated Show resolved Hide resolved
globalping/globalping.go Outdated Show resolved Hide resolved
globalping/globalping.go Outdated Show resolved Hide resolved
globalping/globalping.go Outdated Show resolved Hide resolved
MartinKolarik
MartinKolarik approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@MartinKolarik MartinKolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please continue with the rest in a new PR targeting this branch and I'll merge to master together.

@MartinKolarik MartinKolarik linked an issue Jul 9, 2024 that may be closed by this pull request
Improve error handling v2 #115
Closed
MartinKolarik
MartinKolarik reviewed Jul 9, 2024
View reviewed changes
view/infinite.go Outdated Show resolved Hide resolved
view/infinite.go Outdated Show resolved Hide resolved
cmd/ping.go Outdated Show resolved Hide resolved
@MartinKolarik MartinKolarik mentioned this pull request Jul 9, 2024
Closed
@radulucut radulucut changed the title Add rate limit and credits info - part 1 & api error refactoring Add rate limit and credits info & api error refactoring Jul 10, 2024
@radulucut radulucut changed the title Add rate limit and credits info & api error refactoring feat: add rate limit and credits info & api error refactoring Jul 10, 2024
@MartinKolarik MartinKolarik merged commit 963e544 into jsdelivr:master Jul 10, 2024
3 checks passed
@MartinKolarik MartinKolarik linked an issue Jul 10, 2024 that may be closed by this pull request
Add rate limit and credits info to existing commands #107
Closed
@radulucut radulucut deleted the ratelimit branch July 10, 2024 12:36
@radulucut radulucut mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinKolarik MartinKolarik MartinKolarik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error handling v2 Add rate limit and credits info to existing commands
2 participants
@radulucut @MartinKolarik