Cdn links #1695
Cdn links #1695
Conversation
- Migrated privacy policy to jsDelivr - Removed jobs - Switched GA - Removed some affiliate stuff
|
Fix the build and tests please. Under this PR we can also remove the |
config/_files.yml
Outdated
| @@ -1,338 +1,323 @@ | |||
| bootstrap: | |||
There was a problem hiding this comment.
this file can be removed I think, it was needed when the files were hosted in the repo itself. Now both cdn/ dir and this file can be removed I believe a new one can be generated during build?
There was a problem hiding this comment.
So this files is generated with a new generation script that creates cdn from jsDeliver api. And then later app reads from the file to generate sri and display links on the website.
There was a problem hiding this comment.
Yes so we can remove it from the repo and run it during the build process and generate the file then?
There was a problem hiding this comment.
Yes, I just need to make a small change because the script now requires this file to exist before running the script, but I'll change that to create it on the fly.
So we need to switch to that one? |
|
I was looking at the bootstrap doc like @jimaek said so they still use 4.7.0 |
|
Yes. |
I meant check the format and what files they use, not literally use the same versions. The goal of this migration is to always show the latest available versions for all projects that this site hosts |
config/_files.yml
Outdated
| @@ -54,6 +54,7 @@ bootstrap: | |||
| javascriptEsmSri: sha384-sKZy8g2KJhBTFCD6cIg8d4EifJxaa8c/iYIERdeKorHWhAgZgQOfqOKMe3xBqye1 | |||
There was a problem hiding this comment.
I think this file should be removed completely from the repo. For auto-updates to work we need to generate it during deployment. I dont see a reason to host it in the repo
There was a problem hiding this comment.
I can put it in gitignore
There was a problem hiding this comment.
Do everything you need to delete it from the repo and make sure the tests run on the file that is generated on the fly
I mean that was the latest version for the package I used, how should I know that we need to use @fortawesome/fontawesome-free |
|
What is the command to fix these eslint errors, is annoying to go over them by hand? |
|
@jimaek is there a way to fix these lint errors with puglint, not sure what is a cmd? Can't fix it with |
Maybe |
|
Pug lint doesn't have an auto-fix command. You will need to fix the errors manually. Just don't use tabs and pay attention to indentation since pug needs it. But the errors here are in JS, so |
No description provided.