Use previous columns for reorder logic #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See: * mbrn/material-table#1975 * material-table-core#48 (comment) * Addresses issue where column sorting will unintentially revert to default when props other than the defaultSort changes (such as the data) * Originally, a comparison was made between column props and current sorting. This changes the comparison to between column props and prev column props. * Fixes boolean logic for comparisons * Tested against original reproduction example provided in mbrn/material-table#1868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
Addresses issue where column sorting will unintentially revert to default when props other than the defaultSort changes (such as the data)
Originally, a comparison was made between column props and current sorting. This changes the comparison to between column props and prev column props.
Fixes boolean logic for comparisons
Tested against original reproduction example provided in set defaultSort programmatically mbrn/material-table#1868
Related Issue
Relate the Github issue with this PR using
#Description
Simple words to describe the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:
Impacted Areas in Application
List general components of the application that this PR will affect:
*
Additional Notes
This is optional, feel free to follow your hearth and write here :)