Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gzip support Google Cloud Storage #980

Merged
merged 7 commits into from
Nov 6, 2021

Conversation

jkevingutierrez
Copy link
Contributor

@jkevingutierrez jkevingutierrez commented Feb 8, 2021

Add CompressMixins that can be reused across all storages.

Add the Gzip logic needed for Cloud Storage

@jkevingutierrez
Copy link
Contributor Author

Hey, I'd like to know if there is anything that I should do, so this PR can be reviewed

Copy link
Owner

@jschneier jschneier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions & a few concerns.

tests/test_gcloud.py Outdated Show resolved Hide resolved
storages/compress.py Outdated Show resolved Hide resolved
storages/backends/gcloud.py Show resolved Hide resolved
storages/backends/gcloud.py Outdated Show resolved Hide resolved
storages/backends/gcloud.py Show resolved Hide resolved
storages/backends/gcloud.py Show resolved Hide resolved
storages/backends/gcloud.py Outdated Show resolved Hide resolved
Copy link
Owner

@jschneier jschneier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments.

storages/backends/gcloud.py Outdated Show resolved Hide resolved
storages/backends/gcloud.py Outdated Show resolved Hide resolved
storages/compress.py Outdated Show resolved Hide resolved
@jschneier jschneier merged commit cf50a22 into jschneier:master Nov 6, 2021
mlazowik pushed a commit to qedsoftware/django-storages that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants