Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long deprecated backend GSBotoStorage #518

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Remove long deprecated backend GSBotoStorage #518

merged 1 commit into from
Jul 11, 2018

Conversation

jdufresne
Copy link
Contributor

First deprecated in version 1.6, released on 2017-06-21. Removing the unsupported backend reduces testing and maintenance resources.

@codecov-io
Copy link

codecov-io commented Jul 4, 2018

Codecov Report

Merging #518 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #518      +/-   ##
=========================================
+ Coverage   76.75%   77.1%   +0.35%     
=========================================
  Files          11      10       -1     
  Lines        1596    1520      -76     
=========================================
- Hits         1225    1172      -53     
+ Misses        371     348      -23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f966abd...bb6ebfc. Read the comment docs.

@sww314
Copy link
Contributor

sww314 commented Jul 6, 2018

Looks good. Can you also remove the documentation line:
"It’s possible to access Google Cloud Storage in S3 compatibility mode using other libraries in django-storages, but this is the only library offering native support."

@jdufresne
Copy link
Contributor Author

Thanks for catching that. Done!

@jschneier
Copy link
Owner

I think this is a good idea. My hope is to move to semantic versioning after 1.7 since many people seem to expect that nowadays. The reason I have not been adhering to it is this library was very out of date when first forked (still is in some ways). This will obviously be a breaking change.

What do you think of that plan @jdufresne @sww314?

@jdufresne
Copy link
Contributor Author

@jschneier That works for me. In my other open PRs, I've suggested a few other areas be deprecated or discouraged. Should we consider all of these for a 2.0-ish release?

@jschneier
Copy link
Owner

I'm very happy to start issuing deprecations now. Since it'll probably take some time to get in the major breaking change I want (adjusting how settings is done) I'm cool with any other minor breaking changes we want to roll into 1.7 for now. Nothing is super firm -- it was just a thought I had (could do the same again in 1.8) -- I just don't want to create unnecessary surprises for users.

Personally when I upgrade packages on projects, even with minor version bumps, I read the release notes and go through the commit messages but for ecosystems like node (or even with pip/pipfile?) there can be automatic changes of some nature.

@sww314
Copy link
Contributor

sww314 commented Jul 6, 2018

I agree this probably a 2.0 release with a few more of the issues pulled in.

First deprecated in version 1.6, released on 2017-06-21. Removing the
unsupported backend reduces testing and maintenance resources.
@sww314 sww314 merged commit 46c4bdd into jschneier:master Jul 11, 2018
@jdufresne jdufresne deleted the rm-gs branch August 12, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants