Deprecate old arguments acl & bucket to S3Boto3Storage #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
==========================================
+ Coverage 76.75% 76.92% +0.16%
==========================================
Files 11 11
Lines 1596 1599 +3
==========================================
+ Hits 1225 1230 +5
+ Misses 371 369 -2
Continue to review full report at Codecov.
|
|
👍 @jdufresne how does this work with #524? |
Deprecated in favor of default_acl and bucket_name. Encourage users to upgrade so the deprecated versions can eventually be removed.
|
Thanks!
I'll need to rebase. I'll leave a message in that PR once it is ready. |
|
Sounds good. Just looked at #501 <#501> maybe “acl” is actually a better name? “default" implies you can override it which isn’t the case right?
… On Aug 11, 2018, at 8:46 PM, Jon Dufresne ***@***.***> wrote:
Thanks!
how does this work with #524 <#524>?
I'll need to rebase. I'll leave a message in that PR once it is ready.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#516 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJB2Mi6EGjWltjcUcf5UsXCb5XPAiFsks5uP3rXgaJpZM4VB2WR>.
|
|
That is fine by me. Are yo suggesting "acl" should replace both "default_acl" & "bucket_acl" or only "acl"? Did you want me to handle that as part of this ticket, or separately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in favor of
default_aclandbucket_name. Encourage users to upgrade so the deprecated versions can eventually be removed.