Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS security/session token not being set #514

Closed
wants to merge 1 commit into from
Closed

Fix AWS security/session token not being set #514

wants to merge 1 commit into from

Conversation

alej0varas
Copy link
Contributor

Changed a little the logic for setting backends.s3boto.S3BotoStorage and backends.s3boto3.S3Boto3Storage attributes access_key, secret_key and security_token.
Currently if access_key or secret_key are set security_token is not set.
Code is tested on Lambda.

Fix #282
Related to #283 and #508

@codecov-io
Copy link

codecov-io commented Jun 29, 2018

Codecov Report

Merging #514 into master will decrease coverage by 0.02%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   76.48%   76.46%   -0.03%     
==========================================
  Files          11       11              
  Lines        1595     1589       -6     
==========================================
- Hits         1220     1215       -5     
+ Misses        375      374       -1
Impacted Files Coverage Δ
storages/backends/s3boto.py 88.13% <100%> (+0.09%) ⬆️
storages/backends/s3boto3.py 87.19% <100%> (+0.06%) ⬆️
storages/utils.py 94.73% <83.33%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c76f3...2547f8b. Read the comment docs.

@jschneier
Copy link
Owner

jschneier commented Aug 12, 2018

Thanks! Merged in b13efd9.

@jschneier jschneier closed this Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants