Fix s3boto/s3boto3 memory leak introduced in #504 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by truncating the buffer after uploading it. Follows the approach of jschneier#169.
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 76.44% 76.32% -0.12%
==========================================
Files 11 11
Lines 1592 1584 -8
==========================================
- Hits 1217 1209 -8
Misses 375 375
Continue to review full report at Codecov.
|
vinayinvicible
approved these changes
Jun 5, 2018
|
Thanks for the poke. Opened the rebased version of this at #546. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by truncating the buffer after uploading it. This removes most of the code from #504; let me know if you'd prefer to see cb2e876 reverted.