Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 large multipart uploads #450

Closed

Conversation

tveastman
Copy link
Contributor

@tveastman tveastman commented Jan 15, 2018

This pull request fixes the multipart-upload bug described in #449, the download .read() issue described in #383, and adds a safeguard to prevent opening the file in rw mode, which at the moment would lead to corruption of the object in S3.

@wettenhj
Copy link

Hi @tveastman, see also @jeffcjohnson's PR here: https://github.com/jschneier/django-storages/pull/400/files in response to #383

@jschneier, are there any plans to merge one of these pull requests soon, replacing self._file.write(self.obj.get()['Body'].read()) with self.obj.download_fileobj(self._file)?

gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
… this makes tests happier and works just as well.
gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
… this makes tests happier and works just as well.
gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
… this makes tests happier and works just as well.
@sww314 sww314 added the s3boto label Jul 11, 2018
@jschneier
Copy link
Owner

Going to merge this in #548. Thanks everyone for the help and the patience.

@jschneier jschneier closed this Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants