Send copy of ContentFile.file to upload_fileobj. #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will stop upload_fileobj from modifying the internal file. This is important because the default storage mixin for hashed static files that comes in Django expects files to be open after they are saved, and upload_fileobj closes them.
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 75.82% 75.83% +0.01%
==========================================
Files 11 11
Lines 1551 1552 +1
==========================================
+ Hits 1176 1177 +1
Misses 375 375
Continue to review full report at Codecov.
|
This code is run twice per file, so we don't know if the file has been read before.
|
Sorry, is this another fix for #367? Seems like it's dealing with the same issue. |
|
It could be, but I'm not sure. I'll verify and come back to you. Thanks for taking a look. |
|
Merged #754 to fix this instead, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will stop upload_fileobj from modifying the internal file. This is important because the default storage mixin for hashed static files that comes in Django expects files to be open after they are saved, and
upload_fileobj closes them.