Ensure that we're reading the file from the start #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 75.8% 75.82% +0.01%
==========================================
Files 11 11
Lines 1550 1551 +1
==========================================
+ Hits 1175 1176 +1
Misses 375 375
Continue to review full report at Codecov.
|
|
I've just merged a failing test case for this issue, can you rebase to confirm that this then fixes that and then I would be very happy to merge. |
|
Verified locally, thanks. |
This was referenced Aug 1, 2017
This was referenced Aug 1, 2017
jschneier
pushed a commit
that referenced
this pull request
Aug 14, 2017
jschneier
pushed a commit
that referenced
this pull request
Aug 14, 2017
This was referenced Aug 14, 2017
This was referenced Aug 21, 2017
This was referenced Oct 2, 2017
This was referenced Nov 10, 2017
nitely
pushed a commit
to satellogic/django-storages
that referenced
this pull request
Jul 30, 2018
nitely
pushed a commit
to satellogic/django-storages
that referenced
this pull request
Jul 30, 2018
nitely
pushed a commit
to satellogic/django-storages
that referenced
this pull request
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Django 1.11 as we can no longer assume that the file we're looking is starting from the beginning, this can cause issues with empty files being saved instead of GZ variants.