Allow specification of GS_LOCATION for placing assets in subdirectory. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleclanche
suggested changes
Jul 3, 2017
| try: | ||
| return safe_join(self.location, name) | ||
| except ValueError: | ||
| raise SuspiciousOperation("Attempted access to '%s' denied." % |
There was a problem hiding this comment.
You're not importing SuspiciousOperation
There was a problem hiding this comment.
@jleclanche are there changes still required here?
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
- Coverage 75.58% 75.56% -0.02%
==========================================
Files 11 11
Lines 1544 1551 +7
==========================================
+ Hits 1167 1172 +5
- Misses 377 379 +2
Continue to review full report at Codecov.
|
jleclanche
approved these changes
Aug 19, 2017
|
Any chance this could be merged and released? Seems approved and good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.