Fix safe_join to allow joining a base path with an empty string #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 75.61% 75.61%
=======================================
Files 11 11
Lines 1542 1542
=======================================
Hits 1166 1166
Misses 376 376
Continue to review full report at Codecov.
|
Regression introduced in 895a068
|
Okay can release point release tonight.
… On Jun 21, 2017, at 17:56, Jon Dufresne ***@***.***> wrote:
Regression introduced in 895a068
This regression was my fault. If the PR looks good, I'm hoping this can go out in a bug fix release as 1.6.0 has broken some of my projects. Thanks!
You can view, comment on, or merge this pull request online at:
#336
Commit Summary
Fix safe_join to allow joining a base path with an empty string
File Changes
M CHANGELOG.rst (7)
M storages/utils.py (11)
M tests/test_utils.py (4)
Patch Links:
https://github.com/jschneier/django-storages/pull/336.patch
https://github.com/jschneier/django-storages/pull/336.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I uploaded 1.6.1 |
This was referenced Jun 22, 2017
This was referenced Jun 26, 2017
This was referenced Jul 27, 2017
This was referenced Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in 895a068
This regression was my fault. If the PR looks good, I'm hoping this can go out in a bug fix release as 1.6.0 has broken some of my projects. Thanks!