Fix exists and add modified_time in FTP storage #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirsdeda
changed the title
|
Also added modified_time function |
| # workaround for broken FTP servers returning responses | ||
| # starting with e.g. 1904... instead of 2004... | ||
| if len(s) == 15 and s[:2] == '19': | ||
| s = repr(1900 + int(s[2:5])) + s[5:] |
There was a problem hiding this comment.
let's you str instead of repr here.
There was a problem hiding this comment.
Yeah, str would probably be a better option. I copied this from some path to python's ftplib which was never accepted.
|
Hi and thanks for your contribution. I'm excited that someone is using the FTP backend of this library. I've left a few comments inline and I'd be happy to merge this after they are addressed. |
|
I'm actually using S3, SFTP and FTP. Was using some fork of django-storages-py3 but it's so messed up. Good that I finally found your repo. I'll send some improvements to SFTP backend as well when I get to it. |
|
Changed repr() to str(). Should be good to pull now. |
jschneier
added a commit
that referenced
this pull request
Feb 12, 2015
Fix exists and add modified_time in FTP storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently various FTP servers are inconsistent in NLST command output. Some output only filenames, others output paths. This fix supports both.