Fix TZ awareness in S3Boto3Storage #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JshWright
force-pushed
the
boto3-naive-dt
branch
from
261e40d
to
fda2fe4
Compare
Current coverage is 60.35% (diff: 85.71%)@@ master #181 diff @@
==========================================
Files 18 18
Lines 1652 1657 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 991 1000 +9
+ Misses 661 657 -4
Partials 0 0
|
JshWright
force-pushed
the
boto3-naive-dt
branch
from
fda2fe4
to
0f57410
Compare
Django expects a naive datetime from modified_time()[1]. Django 1.10 adds get_modified_time()[2], which respects USE_TZ. This commit fixes modified_time(), adds get_modified_time(), and adds relevant tests. [1]: https://docs.djangoproject.com/en/1.10/ref/files/storage/#django.core.files.storage.Storage.modified_time [2]: https://docs.djangoproject.com/en/1.10/ref/files/storage/#django.core.files.storage.Storage.get_modified_time
JshWright
force-pushed
the
boto3-naive-dt
branch
from
0f57410
to
f3de7da
Compare
|
Thank you. Guess I need to update...all of the backends for the new Django 1.10 API :p |
jschneier
added a commit
that referenced
this pull request
Aug 5, 2016
This was referenced Nov 8, 2016
This was referenced Dec 17, 2016
This was referenced Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django expects a naive datetime from the modified_time() method.
Django 1.10 adds a get_modified_time() method which respects USE_TZ.
This commit fixes modified_time(), adds get_modified_time(), and adds
relevant tests.