check if underlying file object is closed in closed method #1249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it appears that
S3Boto3StorageFile
uses theclosed
property defined byFileProxyMixin
, which checks the conditionnot self.file or self.file.closed
(source). Sinceself.file
inS3Boto3StorageFile
is a property that delegates to_get_file
, this check reopens the file. Thusclosed
always returnsFalse
.