Support saving file objects that aren't seekable in S3Boto3Storage #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add tests to verify the behavior. This fixes issue jschneier#860.
vainu-arto
force-pushed
the
S3Boto3Storage-save-non-seekable
branch
from
c3835ae
to
304b1b0
Compare
jschneier
pushed a commit
that referenced
this pull request
Sep 19, 2021
* Seek content to zero only once, before compressing * Only seek in S3Boto3Storage._save if content is seekable Also add tests to verify the behavior. This fixes issue #860.
mlazowik
pushed a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 9, 2022
) * Seek content to zero only once, before compressing * Only seek in S3Boto3Storage._save if content is seekable Also add tests to verify the behavior. This fixes issue jschneier#860.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #860.