SFTPStorage silently swallows exception for connection failures

[pansapiens]

Specifically:

django-storages/storages/backends/sftpstorage.py

Lines 81 to 82 in ec9579b

	except Exception as e:
	print(e)

Wouldn't it be better to raise the exception to allow it to be handled by calling code ?
It's been causing issues in my use case, since there's no easy way to handle connection failure to SFTP servers that are offline.

eg attempting to connect to a server that doesn't exist:

from storages.backends.sftpstorage import SFTPStorage

params = dict(port=22,
              username='root',
              password='hunter')
storage = SFTPStorage(host='does-not.exist-domain.example.com', params=params)
storage._connect()
storage.sftp

Outputs:

[Errno -2] Name or service not known
[Errno -2] Name or service not known

rather than raising an exception.

I can work around this issue by calling these private methods before attempting to use the SFTPStorage instance, but it's more of a hacky workaround:

storage._connect()  # so that ._ssh exists
 # will raise an exception if connection fails
storage._ssh.connect(storage._host, **storage._params)

[jschneier]

Yep. If you open a PR I will merge it.

Also, think you mean hunter2 :)

[pansapiens]

Will do. Not sure what you mean by ******* though :)