-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3Boto3: Double localtime() call Exception on modified_time() when settings.USE_TZ=False #234
Comments
piglei
added a commit
to piglei/django-storages
that referenced
this issue
Dec 4, 2016
jschneier
pushed a commit
that referenced
this issue
Jan 12, 2017
Fixed in #235. |
This was referenced Jan 13, 2017
This was referenced Jun 21, 2017
This was referenced Jul 27, 2017
This was referenced Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current implemention of S3Boto3 backend respect USE_TZ settings on Django>=1.10. But when Django<1.10 users set USE_TZ to False,
modified_time()
will raise an ValueError:That's because
get_modified_time()
already returns a naive datetime object,modified_time()
call localtime on this naive object again.The text was updated successfully, but these errors were encountered: