Fix DropBoxBackend.url

CHANGELOG.rst

@@ -1,6 +1,13 @@
 django-storages change log
 ==========================
 
+1.6.4 (XXXX-XX-XX)
+******************
+
+* Fix ``DropBoxStorage.url`` to work. (`#357`_)
+
+.. _#357: https://github.com/jschneier/django-storages/pull/357
+
 1.6.3 (2017-06-23)
 ******************
 

storages/backends/dropbox.py

@@ -101,7 +101,7 @@ def accessed_time(self, name):
 
     def url(self, name):
         media = self.client.files_get_temporary_link(self._full_path(name))
-        return media['link']
+        return media.link
 
     def _open(self, name, mode='rb'):
         remote_file = DropBoxFile(self._full_path(name), self)

tests/test_dropbox.py

@@ -14,6 +14,10 @@
     import mock
 
 
+class F(object):
+    pass
+
+
 FILE_DATE = datetime(2015, 8, 24, 15, 6, 41)
 FILE_FIXTURE = {
     'bytes': 4,
@@ -52,10 +56,8 @@
     'size': '0 bytes',
     'thumb_exists': False
 }
-FILE_MEDIA_FIXTURE = {
-    'link': 'https://dl.dropboxusercontent.com/1/view/foo',
-    'expires': 'Fri, 16 Sep 2011 01:01:25 +0000',
-}
+FILE_MEDIA_FIXTURE = F()
+FILE_MEDIA_FIXTURE.link = 'https://dl.dropboxusercontent.com/1/view/foo'
 
 
 class DropBoxTest(TestCase):
@@ -123,7 +125,7 @@ def test_save(self, *args):
                 return_value=FILE_MEDIA_FIXTURE)
     def test_url(self, *args):
         url = self.storage.url('foo')
-        self.assertEqual(url, FILE_MEDIA_FIXTURE['link'])
+        self.assertEqual(url, FILE_MEDIA_FIXTURE.link)
 
     def test_formats(self, *args):
         self.storage = dropbox.DropBoxStorage('foo')