Skip to content

Add SVG decoding and rendering support to ImageCodec with optional scaling #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yorkie merged 13 commits into from
Jul 31, 2025
Merged

Add SVG decoding and rendering support to ImageCodec with optional scaling #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
98f966e
Initial plan
Copilot Jul 29, 2025
de868c3
Add nanosvg library and implement SVG decoding in ImageCodec
Copilot Jul 29, 2025
cabb498
Improve SVG detection logic to handle HTML with embedded SVG
Copilot Jul 29, 2025
501e12a
update
yorkie Jul 30, 2025
f18cd37
Add optional width and height parameters to ImageCodec::Decode for SV…
Copilot Jul 30, 2025
1be935d
Remove build artifacts from repository
Copilot Jul 30, 2025
19a3c69
Add SVG decoding and rendering support to ImageCodec with optional sc…
Copilot Jul 30, 2025
2613097
fix
yorkie Jul 30, 2025
ada3e6f
fix
yorkie Jul 30, 2025
10ec008
fix
yorkie Jul 30, 2025
bd56941
update
yorkie Jul 30, 2025
7d58db9
fix
yorkie Jul 31, 2025
0bd051d
fix
yorkie Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 38 additions & 5 deletions fixtures/html/images.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,39 @@
<head>
<meta charset="utf-8" />
<title>Images</title>
<style>
body {
background-color: #fff;
padding: 20px 10vw;
box-sizing: border-box;
}

h2 {
margin-bottom: 20px;
font-size: 3.5em;
}

section {
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
gap: 20px;
}

#svg-image:hover {
background-color: #ca4747a8;
}
</style>
</head>

<body style="background-color: #fff;">
<h1>Images:</h1>
<img src="images/jsar-logo-00.png" style="transform:translateZ(10px);height:300px;" />
<img id="placeholder" />
<body>
<h2>Images:</h2>
<section>
<img src="images/jsar-logo-00.png" style="transform:translateZ(10px);height:300px;" />
<img id="svg-image" src="images/react-logo-00.svg" height="300" />
<img id="placeholder" />
</section>
</body>

<script>
Expand Down Expand Up @@ -48,7 +75,7 @@ <h1>Images:</h1>
console.info('new Image(100):', image2, image2.width, image2.height);
const image3 = new Image(100, 200);
console.info('new Image(100, 200):', image3, image3.width, image3.height);
image3.addEventListener('load', function() {
image3.addEventListener('load', function () {
console.info('[load] new Image(100, 200)', image3.width, image3.height);
});
image3.src = image.src;
Expand All @@ -60,6 +87,12 @@ <h1>Images:</h1>
placeholder.setAttribute('src', 'https://ar.rokidcdn.com/web-assets/yodaos-jsar/dist/images/a.jpg');
console.info('placeholder.src:', placeholder.src);
}, 1000);

setTimeout(() => {
// Update the SVG image size dynamically
const svgImage = document.getElementById('svg-image');
svgImage.style.height = '50vh';
}, 1000);
</script>

</html>
3 changes: 3 additions & 0 deletions fixtures/html/images/react-logo-00.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 6 additions & 1 deletion src/client/builtin_scene/web_content_renderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,7 @@ namespace builtin_scene::web_renderer
SkBitmap bitmap;
// TODO(yorkie): support decoding this async?
if (canvas::ImageCodec::Decode(image.getUrlImageData(),
nullptr,
bitmap,
image.getUrl()))
{
Expand Down Expand Up @@ -1035,13 +1036,17 @@ namespace builtin_scene::web_renderer
SkRRect &roundedRect = content.rounded_rect_;
canvas->clipRRect(roundedRect, true);

SkPaint imagePaint;
imagePaint.setAntiAlias(true);
imagePaint.setStyle(SkPaint::kFill_Style);

SkRect srcRect = SkRect::MakeWH(skImage->width(), skImage->height());
SkRect dstRect = SkRect::MakeWH(content.logicalWidth(), content.logicalHeight());
canvas->drawImageRect(skImage,
srcRect,
dstRect,
SkSamplingOptions(),
nullptr,
&imagePaint,
SkCanvas::kStrict_SrcRectConstraint);
}
canvas->restore();
Expand Down
Loading