Update script for latest q cli releases #2
Conversation
Updated command flags for secure and automated operation
|
Resolves #1 |
|
To provide feedback, navigate to the Files changed tab and leave comments on the proposed code changes. Choose Start review for each comment, and then choose Request changes, and I'll propose revised changes. |
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
🔴 I'm not able to complete the code review at this moment because of an internal service error. Please try again later. |
jsamuel1
left a comment
jsamuel1
left a comment
There was a problem hiding this comment.
Can you please use variables for encapsulation of both the tools to trust, and the main prompt string passed to q chat?
jsamuel1
added
the
Amazon Q development agent
git-qcommit
Outdated
| Include what was changed and why. Don't include any markdown formatting or code \ | ||
| blocks.\n\nPrompt: $PROMPT" | q chat -a \ | ||
| --no-interactive \ | ||
| --trust-tools=fs_read,fs_write,execute_bash,internal_command,thinking,\ |
There was a problem hiding this comment.
Please extract out to variables for both the trust-tools list and the initial prompt that is passed to q chat.
|
✅ I updated this pull request based on the feedback. To provide feedback, navigate to the Files changed tab and leave comments on the proposed code changes. Choose Start review for each comment, and then choose Request changes, and I'll propose revised changes. |
Improves code maintainability by moving hardcoded values into dedicated variables. Separates the trusted tools list and chat prompt template into clearly defined constants.
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
🔴 I'm not able to complete the code review at this moment because of an internal service error. Please try again later. |
git-qcommit
Outdated
| INITIAL_PROMPT="Based on the staged git changes, generate a descriptive git \ | ||
| commit message and write it to $TEMP_FILE. Feel free to use appropriate \ | ||
| gitmoji/emoji icons. Include what was changed and why. Don't include any \ | ||
| markdown formatting or code blocks. |
There was a problem hiding this comment.
It looks like we are missing \ on this line and the following line.
|
✅ I updated this pull request based on the feedback. To provide feedback, navigate to the Files changed tab and leave comments on the proposed code changes. Choose Start review for each comment, and then choose Request changes, and I'll propose revised changes. |
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
🔴 I'm not able to complete the code review at this moment because of an internal service error. Please try again later. |
Adds command-line options and trust settings for non-interactive git commit message generation. This change enhances the git-qcommit functionality by explicitly specifying required tool permissions and enabling automation through non-interactive mode.