Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize output #7

Merged
merged 6 commits into from
Oct 10, 2022
Merged

Capitalize output #7

merged 6 commits into from
Oct 10, 2022

Conversation

gewfy
Copy link
Contributor

@gewfy gewfy commented Oct 9, 2022

One more idea here. Using labels as names can be a bit shaky and I'd prefer to not use them. But using the plane object keys leaves me with weirdly named types e.g. posts.

So here's a capitalize option - so type names like general_posts and kitchenSink_list becomes General_Posts and KitchenSink_List.

WDYS? :)

Also thinking about adding an option delimiter for specifying something else than underscore in the type names.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #7 (25ac605) into master (1af362d) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   97.50%   97.65%   +0.15%     
==========================================
  Files          10       10              
  Lines         200      213      +13     
  Branches       66       70       +4     
==========================================
+ Hits          195      208      +13     
  Misses          5        5              
Impacted Files Coverage Δ
src/generate.ts 85.71% <ø> (ø)
src/widget/transform.ts 97.64% <100.00%> (+0.17%) ⬆️
src/input.ts 100.00% <0.00%> (ø)
src/index.ts 85.71% <0.00%> (+2.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@jsaari97 jsaari97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll merge it and prepare a new release.

Regarding custom delimiters, feel free to make a PR, I'll happily merge it. :)

@jsaari97 jsaari97 merged commit 7359b6b into jsaari97:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants