Skip to content

0.3.0 release. #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2021
Merged

0.3.0 release. #99

merged 2 commits into from
Dec 10, 2021

Conversation

12wrigja
Copy link
Contributor

@12wrigja 12wrigja commented Dec 6, 2021

No description provided.

ptomato
ptomato approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

justingrant
justingrant approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Should we add a changelog before release?

@12wrigja
Copy link
Contributor Author

12wrigja commented Dec 7, 2021

Should we add a changelog before release?

Yep - I'll put one into this PR for you both to review.

justingrant
justingrant reviewed Dec 7, 2021
View reviewed changes
@12wrigja
Copy link
Contributor Author

12wrigja commented Dec 7, 2021

I've drafted up a CHANGELOG and intend to reference it from the GH release notes. I looked over all 74 commits in this release and tried to summarize them, but there were definitely some normative changes that I wasn't sure of the external effects and left them out. If there's anything notable you think should be included, feel free to comment :)

justingrant
justingrant reviewed Dec 7, 2021
View reviewed changes
justingrant
justingrant reviewed Dec 7, 2021
View reviewed changes
justingrant
justingrant reviewed Dec 7, 2021
View reviewed changes
justingrant
justingrant reviewed Dec 7, 2021
View reviewed changes
justingrant
justingrant reviewed Dec 7, 2021
View reviewed changes
justingrant
justingrant approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Only general suggestion is that it'd be good to link to the corresponding proposal-temporal PR when there is one.

ptomato
ptomato approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me, I'll defer to Justin's more detailed comments.

justingrant
justingrant reviewed Dec 8, 2021
View reviewed changes
justingrant
justingrant reviewed Dec 8, 2021
View reviewed changes
justingrant
justingrant reviewed Dec 8, 2021
View reviewed changes
@12wrigja
Copy link
Contributor Author

12wrigja commented Dec 9, 2021

Ok - one more PR merged in and added to the changelog.

@justingrant can I get one more look over before merging and starting a release? Thanks.

@12wrigja 12wrigja mentioned this pull request Dec 10, 2021
Closed
justingrant
justingrant approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. A few notes about clarifying which links are actual spec changes and which are simply PRs ported from proposal-temporal or mirrored there.

@12wrigja 12wrigja changed the title Bump package.json in preparation for 0.3.0 release. 0.3.0 release. Dec 10, 2021
@12wrigja 12wrigja merged commit e9c439b into js-temporal:main Dec 10, 2021
@12wrigja 12wrigja deleted the release branch December 10, 2021 23:39
@12wrigja 12wrigja mentioned this pull request Dec 13, 2021
Closed
@12wrigja 12wrigja restored the release branch March 4, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justingrant justingrant justingrant approved these changes

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@12wrigja @justingrant @ptomato