Fix sourcemap warnings in VSCode debugger #193
Conversation
This commit adds the `tsc-out` folder to the package, which will solve the sourcemap warnings you'll see in VSCode in the debugger console.
|
Weird, there are test failures in Node 16, but this PR doesn't make any runtime code changes, so those must be existing failures in the codebase, perhaps caused by a time zone DB update in a Node 16 update? Or perhaps we made a change recently to make Node 17 work well, but it broke Node 16 because the same TZDB hasn't been applied there yet? |
There was a problem hiding this comment.
This seems well-justified to me, but I don't know much about the topic of packaging NPM modules, so I'd prefer to leave the review to @12wrigja.
The test failures look almost certainly due to a TZDB update — in the most recent release, some time zones' pre-1970 data was consolidated. See tc39/test262@0bc0ca1
|
I'll look a bit more closely at the sourcemap setup later today, but wanted to ask if it's possible to pin ourselves to particular versions of this TZ data (by pinning specific Node versions?) so we don't have randomly failing tests. |
|
That should be possible, but it would additionally be good to replace these with tests that won't depend on specific time zone data. |
|
Should we hold this PR waiting for all-green fix for the node 16 time zones? Or OK to merge this one? |
|
I don't think it's necessary to wait for the TZDB fix, but I do think James still wanted to look at the sourcemap setup. |
|
Replaced by #194 |
Fixes #192. by adding the
tsc-outfolder to the package, which will solve the sourcemap warnings you'll see in VSCode in the debugger console.It's possible that there may be some other way to fix sourcemaps without making the package larger, but at least in the meantime we can fix the debugger console warnings while we look for a better solution if one exists.