Skip to content

add solutions for accordion #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add solutions for accordion #11

wants to merge 6 commits into from

Conversation

@JSPandaDev
Copy link
Contributor

@JSPandaDev JSPandaDev commented Oct 23, 2025

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 23, 2025

Добавляю преподавателя (@GSemikozov) для код-ревью.

@jsru-1 jsru-1 requested a review from GSemikozov October 23, 2025 00:56
GSemikozov
GSemikozov requested changes Oct 23, 2025
View reviewed changes
03-lection1/02-accordion/index.html Outdated
</summary>
<p>
Hidden content
<p class="accordion__text">
Copy link

@GSemikozov GSemikozov Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше div и accordion__content

Copy link

@GSemikozov GSemikozov Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

здесь не исправлено

Copy link
Contributor Author

@JSPandaDev JSPandaDev Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Добавляю преподавателя (@GSemikozov) для код-ревью.

@jsru-1 jsru-1 requested a review from GSemikozov October 25, 2025 15:18
@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Решение было обновлено, посмотрим что скажет @GSemikozov

6 similar comments
@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Решение было обновлено, посмотрим что скажет @GSemikozov

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Решение было обновлено, посмотрим что скажет @GSemikozov

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Решение было обновлено, посмотрим что скажет @GSemikozov

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Решение было обновлено, посмотрим что скажет @GSemikozov

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Решение было обновлено, посмотрим что скажет @GSemikozov

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 25, 2025

Решение было обновлено, посмотрим что скажет @GSemikozov

GSemikozov
GSemikozov requested changes Oct 27, 2025
View reviewed changes
03-lection1/02-accordion/accordion.css Outdated
line-height: 24px;
letter-spacing: 0%;
list-style-type: none;
padding: 24px 0 24px 32px;
Copy link

@GSemikozov GSemikozov Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

справа тоже нажо

Copy link
Contributor Author

@JSPandaDev JSPandaDev Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а для чего правый отступ?
Слева же указан, справа всё оставшееся пр-во

Copy link

@GSemikozov GSemikozov Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а если добавить текст fvgf fgbfgb fgbfg bgfb fb fgbgfbgfbg bgfbgfbg fbgfbg fbgfb gfbgfb gfbfgb dbg?

GSemikozov
GSemikozov requested changes Oct 28, 2025
View reviewed changes
03-lection1/02-accordion/accordion.css Outdated
line-height: 24px;
letter-spacing: 0%;
list-style-type: none;
padding: 24px 0 24px 32px;
Copy link

@GSemikozov GSemikozov Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а если добавить текст fvgf fgbfgb fgbfg bgfb fb fgbgfbgfbg bgfbgfbg fbgfbg fbgfb gfbgfb gfbfgb dbg?

03-lection1/02-accordion/index.html Outdated
</summary>
<p>
Hidden content
<p class="accordion__text">
Copy link

@GSemikozov GSemikozov Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

здесь не исправлено

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSemikozov GSemikozov GSemikozov requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JSPandaDev @jsru-1 @GSemikozov @ZhPavelA