Skip to content

Conversation

@pavankjadda
Copy link
Contributor

No description provided.

@pavankjadda pavankjadda requested a review from Copilot July 2, 2025 02:15
@pavankjadda pavankjadda self-assigned this Jul 2, 2025
@pavankjadda pavankjadda added the enhancement New feature or request label Jul 2, 2025
@netlify
Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for js-react-kit ready!

Name Link
🔨 Latest commit ea32cd9
🔍 Latest deploy log https://app.netlify.com/projects/js-react-kit/deploys/68649683f5c51e00083b34e2
😎 Deploy Preview https://deploy-preview-29--js-react-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 2, 2025

View your CI Pipeline Execution ↗ for commit 8d9469d.

Command Status Duration Result
nx test react-kit ✅ Succeeded 9s View ↗
nx build react-kit ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-02 02:15:54 UTC

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches TypeScript’s module resolution strategy to bundler, standardizes component props with Readonly<> wrappers, and updates package configurations to ES modules and newer dependency versions.

  • Change moduleResolution in tsconfig.base.json to bundler
  • Introduce Readonly<Props> for React components and define dedicated Props interfaces
  • Add "type": "module" and bump package versions across root and react-kit package

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsconfig.base.json Change "moduleResolution" from "node" to "bundler"
react-kit/src/lib/components/buttons/EditIconButton.tsx Wrap props in Readonly<EditIconButtonProps>
react-kit/src/lib/components/OpenInNewIconLink.tsx Rename interface to Props and wrap props in Readonly<Props>
react-kit/src/lib/components/NextLink.tsx Add Props interface and wrap props in Readonly<Props>
react-kit/package.json Add "type": "module", bump peerDeps, remove @mui/lab
package.json Bump version to 5.6.0, add "type": "module", update dependencies
.github/copilot-instructions.md Add Copilot instructions document
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (4)

react-kit/src/lib/components/OpenInNewIconLink.tsx:6

  • [nitpick] The interface name 'Props' is too generic and can lead to naming collisions; consider renaming it to 'OpenInNewIconLinkProps' for clarity and consistency.
interface Props {

react-kit/src/lib/components/NextLink.tsx:5

  • [nitpick] Consider using a more descriptive interface name like 'NextLinkProps' instead of a generic 'Props' to improve readability and avoid conflicts.
interface Props {

react-kit/package.json:13

  • Removing '@mui/lab' from peerDependencies may break components relying on lab packages. Please verify if lab components are no longer used or re-add as needed.
    "@emotion/styled": "^11.14.1",

package.json:20

  • This change downgrades '@mui/x-data-grid' from v8 to v7; if code relies on v8 features, this may cause compatibility issues. Please confirm this downgrade is intentional.
    "@mui/x-data-grid": "^7.29.7",

pavankjadda and others added 2 commits July 1, 2025 22:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pavankjadda pavankjadda merged commit d6e352e into main Jul 2, 2025
1 check passed
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants