-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: change module resolution to bundler #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for js-react-kit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 8d9469d.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR switches TypeScript’s module resolution strategy to bundler, standardizes component props with Readonly<> wrappers, and updates package configurations to ES modules and newer dependency versions.
- Change
moduleResolutionintsconfig.base.jsontobundler - Introduce
Readonly<Props>for React components and define dedicatedPropsinterfaces - Add
"type": "module"and bump package versions across root andreact-kitpackage
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Change "moduleResolution" from "node" to "bundler" |
| react-kit/src/lib/components/buttons/EditIconButton.tsx | Wrap props in Readonly<EditIconButtonProps> |
| react-kit/src/lib/components/OpenInNewIconLink.tsx | Rename interface to Props and wrap props in Readonly<Props> |
| react-kit/src/lib/components/NextLink.tsx | Add Props interface and wrap props in Readonly<Props> |
| react-kit/package.json | Add "type": "module", bump peerDeps, remove @mui/lab |
| package.json | Bump version to 5.6.0, add "type": "module", update dependencies |
| .github/copilot-instructions.md | Add Copilot instructions document |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (4)
react-kit/src/lib/components/OpenInNewIconLink.tsx:6
- [nitpick] The interface name 'Props' is too generic and can lead to naming collisions; consider renaming it to 'OpenInNewIconLinkProps' for clarity and consistency.
interface Props {
react-kit/src/lib/components/NextLink.tsx:5
- [nitpick] Consider using a more descriptive interface name like 'NextLinkProps' instead of a generic 'Props' to improve readability and avoid conflicts.
interface Props {
react-kit/package.json:13
- Removing '@mui/lab' from peerDependencies may break components relying on lab packages. Please verify if lab components are no longer used or re-add as needed.
"@emotion/styled": "^11.14.1",
package.json:20
- This change downgrades '@mui/x-data-grid' from v8 to v7; if code relies on v8 features, this may cause compatibility issues. Please confirm this downgrade is intentional.
"@mui/x-data-grid": "^7.29.7",
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 5.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.