Skip to content

jsonapi-serde.js.org #9834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

jsonapi-serde.js.org #9834

merged 1 commit into from
Jun 3, 2025

Conversation

DASPRiD
Copy link
Contributor

@DASPRiD DASPRiD commented Jun 2, 2025

The site content is Vitepress documentation for jsonapi-serde.

Not too sure if the subdomain name is okay though. In general it conflicts with your naming rules:

Must either be the username or the sub path.

I have suffixed the repository name with -js, as I plan to have a similar project to be written in Rust, which would then get -rs suffix in my repository list. So the suffix is just for avoiding naming collisions, and I'd prefer to not have js twice in the url: json-serde-js.js.org, if possible :)

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error notes, your entry needs to be in alphabetical order, and doesn't need the https:// prefix.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/DASPRiD/jsonapi-serde-js/tree/main/packages/docs/src

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed invalid labels Jun 2, 2025
@indus
Copy link
Member

indus commented Jun 3, 2025

Welcome https://jsonapi-serde.js.org

@indus indus merged commit 37e4d23 into js-org:master Jun 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants