Skip to content

cath.js.org #9680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

cath.js.org #9680

merged 3 commits into from
Apr 9, 2025

Conversation

night0721
Copy link
Contributor

  • [ v] There is reasonable content on the page (see: No Content)
  • [ v] I have read and accepted the Terms and Conditions
  • The site content can be seen at

The site content is a npm package that can easily interact and get data from NYX API

@night0721
Copy link
Contributor Author

Uhh not sure why it failed

@MattIPv4 MattIPv4 changed the title Update cnames_active.js cath.js.org Apr 8, 2025
@MattIPv4
Copy link
Member

MattIPv4 commented Apr 8, 2025

CI failure is not your fault, #9681 will fix it.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://cath-docs.pages.dev/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels Apr 8, 2025
@indus
Copy link
Member

indus commented Apr 9, 2025

@night0721 I've just made the change to JS.ORGs zonefile but get an Error 1014.

You may have to follow this from the wiki to make it work:
For Cloudflare Pages, you will need to add the JS.ORG subdomain to your project as a custom domain via the API: https://developers.cloudflare.com/api/operations/pages-domains-add-domain -- it is not possible to add the JS.ORG subdomain as a custom domain through the Cloudflare dashboard.

I'll merge after we have "contact". Please keep this PR open.

@indus indus added the error The page requested returns an error label Apr 9, 2025
@night0721
Copy link
Contributor Author

image

@indus I assume this is working then, thank you!

@indus
Copy link
Member

indus commented Apr 9, 2025

Welcome back https://cath.js.org

@indus indus merged commit cdf78fc into js-org:master Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain error The page requested returns an error external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants