Skip to content

Conversation

vtempest
Copy link
Contributor

@vtempest vtempest commented Dec 1, 2024

I have read the instructions

The site content is about starter docs stack for svelte

I have read the instructions
@indus indus changed the title added starter docs stack for svelte starterdocs.js.org Dec 1, 2024
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Dec 1, 2024
@indus
Copy link
Member

indus commented Dec 1, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line starterdocs.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

@vtempest
Copy link
Contributor Author

vtempest commented Dec 1, 2024

@vtempest
Copy link
Contributor Author

vtempest commented Dec 2, 2024

Does that work?

@indus
Copy link
Member

indus commented Dec 2, 2024

@vtempest No - Because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

You can check status on your own: https://starterdocs.js.org/
But please keep the PR open so I can merge when things work fine.

@vtempest
Copy link
Contributor Author

vtempest commented Dec 2, 2024

ok i changed to sveltestarter.js.org and fixed cname

@indus
Copy link
Member

indus commented Dec 2, 2024

@vtempest Why? My understanding was that "docs" is an acronym for a very specific tech-stack?!

"sveltestarter" sounds like a generic boilerplate/template and we don't allow those. The change also messes up the alphabetical order.

@vtempest
Copy link
Contributor Author

vtempest commented Dec 3, 2024

Okay changed back to "starterdocs": and uplaoded cname with typedoc

@indus
Copy link
Member

indus commented Dec 3, 2024

@vtempest still no success. Did you follow those: #7853 (comment) / #8532 (comment) ?

@indus
Copy link
Member

indus commented Dec 5, 2024

@vtempest: I will have to close this if you can't resolve the issues on your side.

@vtempest
Copy link
Contributor Author

vtempest commented Dec 7, 2024

sorry for the delay. fixed.

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Dec 7, 2024
@indus
Copy link
Member

indus commented Dec 7, 2024

Welcome https://starterdocs.js.org

@indus indus merged commit 97c7270 into js-org:master Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants