Skip to content

sign-poc.js.org #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024
Merged

sign-poc.js.org #8985

merged 1 commit into from
May 2, 2024

Conversation

imcotton
Copy link
Contributor

@imcotton imcotton commented May 2, 2024

It's in private GitHub repo currently, but has CNAME file placed in sign-poc/CNAME.

Thanks.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels May 2, 2024
@indus
Copy link
Member

indus commented May 2, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But I get a redirect error. In case you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@indus indus added the error The page requested returns an error label May 2, 2024
@imcotton
Copy link
Contributor Author

imcotton commented May 2, 2024

Thanks for the approve, I manually toggled dropdown between branch and action and it works correctly now.

One little thing: the site seems been proxied via CF? Which means the noCF flag not into account, no?

@indus indus removed the error The page requested returns an error label May 2, 2024
@indus
Copy link
Member

indus commented May 2, 2024

One little thing: the site seems been proxied via CF? Which means the noCF flag not into account, no?
Sorry I missed to disable but made the change just now. It may take some time untill TTL passes by and the new setting propagates .

Welcome https://sign-poc.js.org

@indus indus merged commit 86f75c2 into js-org:master May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants