sjpm.js.org

[cosmixcom]

• There is reasonable content on the page (see: No Content)
• I have read and accepted the Terms and Conditions

[MattIPv4]

cc #8944 -- just as a note for the future, you don't need to create a new PR (and send notifications to everyone) when you make a change to your branch, it will show up in the original PR just fine.

[MattIPv4]

I'm looking at https://github.com/toggledtech/SJPM/blob/3041299245a6e2e9c6f5f8581733ec2a867905ba/index.html and struggling to deem this sufficient content for a site. It very much feels like placeholder content, with a link to documentation on your own domain, not the js.org site. @indus, thoughts?

[indus]

It very much feels like placeholder content, with a link to documentation on your own domain, not the js.org site. @indus, thoughts?

@MattIPv4 This doesn't sound much diffren then https://vue.js.org for example; I think that is ok.

But I'm having a hard time to actually have a look at the content in question. As I get a redirect error.
@cosmixcom I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

Please keep this PR open to give me a chance to have a look at your page and merge the request if it fullfils our requirements.

[MattIPv4]

@MattIPv4 This doesn't sound much diffren then https://vue.js.org for example; I think that is ok.

👍 If you're fine with it, I'm fine with it. The only thing I'd note is that the sites like vue.js.org exist to save lost users looking for vuejs.org. I don't think sjpmjs.org exists, so this comparison might not hold true here?

[cosmixcom]

Thanks for your help. I got the site running, the page just only functions properly on a private domain.

The issue was that any of the buttons linking to other pages on the site had hrefs like . And on a private domain that will go to domain.com/dashboard, but on GitHub pages it redirects to toggledtech.github.io/dashboard instead of toggledtech.github.io/SJPM/dashboard.

[indus]

Welcome https://sjpm.js.org