Skip to content

warlock.js.org #8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2024
Merged

warlock.js.org #8943

merged 2 commits into from
Apr 13, 2024

Conversation

warlockjs
Copy link
Contributor

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/warlockjs/documentation/tree/gh-pages/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Apr 11, 2024
@indus
Copy link
Member

indus commented Apr 12, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line warlock.js.org to make it work. This is incorrect it has to be named "CNAME" .
I'll merge after we have "contact". Please keep this PR open.

@indus indus added the invalid label Apr 12, 2024
@warlockjs
Copy link
Contributor Author

@indus Thanks for the update, i've updated the file name to be CNAME, sorry for the typo.

@indus indus removed the invalid label Apr 13, 2024
@indus
Copy link
Member

indus commented Apr 13, 2024

Welcome https://warlock.js.org

@indus indus merged commit dbbec21 into js-org:master Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants