Skip to content

oslo.js.org #8601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2023
Merged

oslo.js.org #8601

merged 1 commit into from
Oct 28, 2023

Conversation

pilcrowonpaper
Copy link
Contributor

Oslo is a TS library that provides a collection of auth utilities.

Repo: https://github.com/pilcrowOnPaper/oslo
NPM: https://www.npmjs.com/package/oslo
Docs repo: https://github.com/pilcrowOnPaper/oslo/tree/main/docs

The website uses Astro, and I have added the CNAME file here

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 27, 2023
@pilcrowonpaper
Copy link
Contributor Author

I thought that was unnecessary if I have the CNAME file?

@pilcrowonpaper
Copy link
Contributor Author

I'm not sure, but I added it just in case

@MattIPv4
Copy link
Member

The CNAME file works if you're deploying GitHub Pages using the legacy branch method. If you're using GitHub Actions to deploy directly to GitHub Pages though, you'll need to use the repository setting. You can tell when it's working, because the GitHub.io URL will start redirecting.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/pilcrowOnPaper/oslo/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Oct 27, 2023
@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 27, 2023
@indus
Copy link
Member

indus commented Oct 27, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@pilcrowonpaper
Copy link
Contributor Author

Not sure what I did exactly, but got it working!

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 28, 2023
@indus
Copy link
Member

indus commented Oct 28, 2023

Welcome https://oslo.js.org

@indus indus merged commit f711f93 into js-org:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants