Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

german.js.org #2402

Merged
merged 2 commits into from
Oct 10, 2018
Merged

german.js.org #2402

merged 2 commits into from
Oct 10, 2018

Conversation

DipanshKhandelwal
Copy link
Contributor

MattIPv4
MattIPv4 approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Site appears to have content (based on repo), commit valid, CNAME present.
Lgtm.

@indus
Copy link
Member

indus commented Oct 10, 2018

Herzlich Willkommen https://german.js.org
(Maybe you page could use this as an itroductury 😆)

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Oct 10, 2018
@indus indus merged commit 2d56828 into js-org:master Oct 10, 2018
@DipanshKhandelwal
Copy link
Contributor Author

@indus Yes sure thanks 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DipanshKhandelwal @indus @MattIPv4